From ac40b79f002a2315f909548614ccd2d408da25b7 Mon Sep 17 00:00:00 2001 From: Laurent Pinchart Date: Thu, 15 Nov 2012 11:30:44 +0100 Subject: media: Fix valgrind warnings valgrind has no way to know that the kernel will fill links and pads arrays passed to an ioctl through __user pointers. Allocate the arrays with calloc() to make sure they get initialized. This also fixes the potential integer overflow. Signed-off-by: Laurent Pinchart Acked-by: Sakari Ailus --- src/mediactl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mediactl.c b/src/mediactl.c index 14cff30..46562de 100644 --- a/src/mediactl.c +++ b/src/mediactl.c @@ -206,8 +206,8 @@ static int media_enum_links(struct media_device *media) unsigned int i; links.entity = entity->info.id; - links.pads = malloc(entity->info.pads * sizeof(struct media_pad_desc)); - links.links = malloc(entity->info.links * sizeof(struct media_link_desc)); + links.pads = calloc(entity->info.pads, sizeof(struct media_pad_desc)); + links.links = calloc(entity->info.links, sizeof(struct media_link_desc)); if (ioctl(media->fd, MEDIA_IOC_ENUM_LINKS, &links) < 0) { media_dbg(media, -- cgit v1.2.3